Add Windows support #35
Conversation
|
first time caller, working on my first shopify project for a client - what is yalls release cycle like such that |
|
Hey @bobmagicii, we typically release 1-2 times per week depending on the number of commits. |
| async function which(command) { | ||
| const whichCmd = isWin ? 'where' : 'which'; | ||
| const { stdout } = await exec(`${whichCmd} ${command}`); | ||
| return stdout.split('\n')[0].replace('\r', ''); |
| @@ -29,11 +29,11 @@ | |||
| "url": "https://github.com/shopify/theme-check-vscode.git" | |||
| }, | |||
| "scripts": { | |||
| "prebuild": "yarn && rm -rf dist language-configuration.json", | |||
| "prebuild": "yarn && rimraf dist language-configuration.json", | |||
There was a problem hiding this comment.
Looks like npm run somehow handles it because that's how I was running the server over there.
| @@ -47,7 +48,7 @@ async function startServer() { | |||
| }; | |||
|
|
|||
| client = new LanguageClient( | |||
| 'theme-check', | |||
| 'shopifyLiquid', | |||
There was a problem hiding this comment.
For consistency with the configuration. This way you can set
"shopifyLiquid.trace.server": "verbose"
In your VS Code settings.json and see the lsp logs in the Output pane. Leaving it as theme-check meant that it had to be "theme-check.server.logs" which feels out of place with the rest of the configuration options.
Fixes #5
Depends on Shopify/theme-check#364